Skip to content
This repository has been archived by the owner on Apr 16, 2023. It is now read-only.

[WIP] Proposal for property change listeners on client objects #96

Draft
wants to merge 1 commit into
base: bleeding-1.X.X
Choose a base branch
from

Conversation

MarkL4YG
Copy link
Member

@MarkL4YG MarkL4YG commented Sep 5, 2019

Introduces property change listeners on special IDataHolder instances.
Proposed implementation:

  • Synchronously run listeners directly after the property has been changed.
  • Defer running listeners during client cache update and run them after the update is completed
  • Document that changing properties in an update listener is considered an anti-pattern but do not enforce.
  • TODO: Document that listeners should not be invoking any sort of load bearing code due to their synchronous nature.
  • TODO: Write documentation about this feature on ReadMe.IO

Closes: #95

@MarkL4YG MarkL4YG added this to the Stable Release 1.1.0 milestone Sep 5, 2019
@MarkL4YG
Copy link
Member Author

MarkL4YG commented Sep 5, 2019

@genius42 please review the proposed API addition.

@MarkL4YG MarkL4YG self-assigned this Sep 25, 2019
@MarkL4YG MarkL4YG added api Related to API changes / additions (internal API) performance Performance impacting stuff ts-workaround Work-arounds for inconsistencies or bugs in TeamSpeak's API. labels Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Related to API changes / additions (internal API) performance Performance impacting stuff ts-workaround Work-arounds for inconsistencies or bugs in TeamSpeak's API.
Development

Successfully merging this pull request may close these issues.

[🚀] Custom event when significant client properties change
2 participants